AB#271221 - Add defensive null and remove redundant city code#69
Open
AB#271221 - Add defensive null and remove redundant city code#69
Conversation
- SessionHelper.isLaunchActivity: Add null check for activity.getComponentName() to prevent NullPointerException when component name is null - DeviceInfoProvider.getCityNameFromLocation: Add coordinate validation to prevent IllegalArgumentException from Geocoder when latitude/longitude values are out of valid range (latitude: -90 to 90, longitude: -180 to 180)
…oadcastReceiver - Add initialization checks in Optimobile.trackEvent() and related methods - Add null check in PushBroadcastReceiver.maybeTriggerInAppSync() - Remove getCityNameFromLocation() method from DeviceInfoProvider - Update EventGenerator to pass null for location city name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionHelper.isLaunchActivity: Add null check for activity.getComponentName() to prevent NullPointerException when component name is null
DeviceInfoProvider.getCityNameFromLocation: removed this now redundant method
Description of Changes
Adding in defensive checks when it comes to validating latitude/longitude values and potential null checks in getComponentName where it could be possible in some edge cases
Breaking Changes
Release Checklist
Prepare:
Bump versions in:
Integration tests
T&T Only
Mobile Only
Deferred Deep Links
Combined
Release Procedure
devtomaster